feat: UI setup for feedback component hidden behind feature flag #2632
Conversation
|
Removed vultr server and associated DNS entries |
ianjon3s
force-pushed
the
ian/feedback-ui-components
branch
2 times, most recently
from
ec69511 to
efddec1
Compare
Mike-Heneghan
force-pushed
the
ian/feedback-ui-components
branch
from
6643b26 to
9e1f2e8
Compare
Mike-Heneghan
force-pushed
the
ian/feedback-ui-components
branch
from
9e1f2e8 to
b67963a
Compare
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Tracked Tables (3) |
|
|
||
| CREATE TABLE "public"."feedback_type_enum" ("value" text NOT NULL, "comment" text NOT NULL, PRIMARY KEY ("value") );COMMENT ON TABLE "public"."feedback_type_enum" IS E'Store the different types of feedback we gather from user'; | ||
|
|
||
| INSERT INTO "public"."feedback_type_enum"("value", "comment") VALUES (E'issue', E' A user reporting an issue with a service'); |
There was a problem hiding this comment.
| INSERT INTO "public"."feedback_type_enum"("value", "comment") VALUES (E'issue', E' A user reporting an issue with a service'); | |
| INSERT INTO "public"."feedback_type_enum"("value", "comment") VALUES (E'issue', E'A user reporting an issue with a service'); |
There was a problem hiding this comment.
I've made this change on another branch so this comment hasn't been lost 😌
Mike-Heneghan
force-pushed
the
ian/feedback-ui-components
branch
from
b67963a to
7948267
Compare
- Reinstate the feedback fish PhaseBanner - Move the new feedback banner into it's own component - Conditionally render the new UI when featureFlag is present
- Split the new UI into it's own component - Conditionally render the new UI when the feature flag is enabled
Mike-Heneghan
force-pushed
the
ian/feedback-ui-components
branch
from
3d5e146 to
3dfc7d1
Compare
Mike-Heneghan
changed the title
| @@ -59,6 +62,8 @@ const CloseButton = styled("div")(({ theme }) => ({ | |||
| color: theme.palette.text.primary, | |||
| })); | |||
|
|
|||
| const isUsingFeatureFlag = () => hasFeatureFlag("SHOW_INTERNAL_FEEDBACK"); | |||
There was a problem hiding this comment.
I think we'd save a few renders by just making this a static value?
const isUsingFeatureFlag = hasFeatureFlag("SHOW_INTERNAL_FEEDBACK");
There was a problem hiding this comment.
That's an interesting one, I think I just copied the pattern from the other places where a feature flag is used and didn't stop to think about it 😅
I'll experiment with making it static to see whether it's like this for a reason or maybe just causing unnecessary renders.
There was a problem hiding this comment.
Experimenting with this it seems the static version is grand, when the flag is toggled it triggers the refresh so it seems to be working as intended.
Fixed: adcb8c2
| <Typography variant="body2"> | ||
| Please do not include any personal or financial information in your | ||
| feedback. If you choose to do so we will process your personal data | ||
| according to our <Link>privacy policy</Link>. |
There was a problem hiding this comment.
We'll need to make a note to come back and populate this link. Maybe let's make it visually obvious with <Link href="#">privacy policy (TODO)</Link>
- As per #2632 (comment) - Add explicit TODO note to component
What
Why
Testing
window.featureFlags.toggle("SHOW_INTERNAL_FEEDBACK")Screen recording